Ticket #7 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

internationalisation of output messages

Reported by: anonymous Assigned to: somebody
Priority: minor Milestone:
Component: PhotoField Version:
Keywords: Cc:

Description

Actualy I've seen only one place where you've hardcoded english "Delete" message in DeleteCheckbox. It's common good idea to borrow "Delete" transtaion from Django: 

from django.forms import CheckboxField
from django.utils.translation import gettext

class DeleteCheckbox(CheckboxField):

    def __init__(self, field_name, checked_by_default=False, validator_list=None, is_required=False):
        super(DeleteCheckbox, self).__init__(field_name, checked_by_default, validator_list)

    def render(self, data):
        checked_html = ''
        if data or (data is '' and self.checked_by_default):
            checked_html = ' checked="checked"'
        del_str = gettext("Delete")
        return '&nbsp;&nbsp;%s&nbsp;<input type="checkbox" id="%s" class="v%s" name="%s"%s value="on" />' % \
            (del_str, self.get_id(), self.__class__.__name__,
            self.field_name, checked_html)

Change History

09/09/06 22:26:31 changed by bryan

  • status changed from new to closed.
  • resolution set to fixed.

Thanks for pointing this out. Fixed in [17].

Ian, could you make sure that this gets integrated into the next version of our patch for Django ticket #2534.